if statement - How do you write the error checking part of a method to make it readable and error prone? -

-

I had a disagreement with another programmer about how many errors are to be typed with the method: 

  Public Zero Execution () {if (test1) {if (test2) {if (test3) {// DO STUFF} and {return "Error 3"; }} And {return "Error 2"; }} And {return "error 1"; }}   
 -  
  Public Zero Execution () {If (Test1) {Return "Error 1"; } If (! Examination 2) {return "Error 1"; } If (! Examination 3) {return "Error 1"; } // DO STUFF}   
 For me,  If  making a dark nest of the statement makes it difficult to read the first example. 
 The second, despite having three  returns  s, is more readable.  
 I have examined the curiosity about what the code was saying and it believes me less about how it handles it:  
 
 under the nest The heap of error conditions indicates the well written error processing code.   
 But then  
 
 If the main body of the routine is closed around then the statement becomes unconscious, especially if the maximum code in the statement it happens.   
 And considering using the Guard Clauses, as a second example  
 
 Minimize the number of returns in each routine. This is a regular form. It is difficult to understand from, when reading it below, you are unaware of the possibility that this is something-where is returned above.   
 How do you write error checking part of the method to make it readable and error prone?   
 
 
 Programmer did not find anything faster than the stylistic debate in combat () then briefly answered "Whatever style you and your team decides is best for your project / language."  
 It is being said, I would like to add two cents for the comment of the code complete about the multiple returns, many   successful   returns, and Distinguish between multiple returns. If I need to check the 5 returns that are not due to errors, then the function must be rewritten. If you exit your work immediately after passing the error, then a maintenance programmer (i.e. you in 6 months) should not have any more problems after the main argument of your function, if you want to check all those errors Had nested.  
 So, my personal opinion is that your second code example is a better option.

Comments

Post a Comment

Popular posts from this blog

php - PDO bindParam() fatal error -

-
I am trying to learn PDO, now I have written this small code, but it gives me a serious error: < P> Fatal error: Call a member function at a non-object dot () ... $ con = new mysqli ("127.0.0.1", "root", "", "csvdangercheck"); $ Query = $ con- & gt; ("Id,` var1`, `var2`) values ​​(" id,: var1,: var2) ";); $ query- & gt; bypass pattern (': id', $ id); $ query- & gt; BindParam (': var1', $ VAL1); $ Query- & gt; bindParam (': var2', $ val2); $ Query-> Executed (); I Trying to use print_r ($ con-> errorInfo ()) but Fatal error: Undefined method mysqli :: errorInfo ( ) ... can someone tell me what am I missing? Flaffeh said, you have PDO Missing Mysqy, try it: $ con = new PDO ('mysql: host = 127.0.0.1; dbname = csvdangercheck', 'root', '');
Read more

logging - How can I log both the Request.InputStream and Response.OutputStream traffic in my ASP.NET MVC3 Application for specific Actions? -

-
For a specific set of tasks, I need to log in to the incoming request inputstream as well as outgoing response. is. I am using an ActionFilterAttribute for this and overriding the OnActionExecuted and OnResultExecuted methods. So I'm starting with this idea ... Public category ActionLoggerAttribute: ActionFilterArrbit {Public Override Zero On-Offed Execution (ActionActioned Contact Filter Filter) {base.OnActionAxecuted (FilterContext); HttpRequestBase request = filterContext.HttpContext.Request; // TODO: Log the request. InputStream} Public Override Zero OnResultExecuted (ResultExecutedContext FilterContext) {base.OnResultExecuted (filterContext); HTTPRPSPointBase Response = FilterContacts Hpptex response; // TODO: Log on Response.OutputStream}} Ideally I'll hook it up with enterprise library logging because I'm already using it for error logging. Am I reaching the input and output stream at the right time? Can I easily use the Enterprise Library to log i
Read more

java - Why my included JSP file won't get processed correctly? -

-
I am trying to create Java web framework (and learning), and on the basis of 'Code Generator In the process of making the material view of the database in the process of development, I stumbled into a difficulty, which I do not know how to solve it. First of all, I want the following index.jsp : & lt; Body & gt; Use all pages to be created. & Lt;% @ include file = "header.jsp"% & gt; & Lt; Hours / & gt; & Lt;% @ included file = "body.jsp"%> & Lt; Hours / & gt; & Lt;% @ include file = "footer.jsp"% & gt; & Lt; / Body & gt; And, in body.jsp , I should have it like this: & lt; Jsp: include page = "$ {Application_modul}"%> Where application_modul is an attribute defined in its controller: request.setAttribute ("application_modul", "USER_ACCOUNT \\ ' View_user_account.jsp "); This file can be found properly, but the processed JSP does
Read more